Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not default to preloading HSTS #727

Closed
lgarron opened this issue Jan 7, 2017 · 2 comments
Closed

Do not default to preloading HSTS #727

lgarron opened this issue Jan 7, 2017 · 2 comments

Comments

@lgarron
Copy link

lgarron commented Jan 7, 2017

What is the current behavior?

The HSTS defaults include
nginx_hsts_preload: true

What is the expected or desired behavior?

Sites that enable HSTS should not send the preload directly by default.
I was contacted by someone who unintentionally ended up on the preload list. Removal is slow and painful for such sites: https://hstspreload.org/#removal
(I deal with multiple removal requests daily.)

Preloaded HSTS should never be the default setting. It has no effect unless the site is submitted to https://hstspreload.org , which should be done with the knowledge and consent of the site operator. It's fine to encourage preloaded HSTS, but it should be an explicit opt-in.

I would send a pull request to change the default value, but I don't know how to handle the migration path for existing project that rely on the default value to stay preloaded. However, the setting should be false for new projects.

@swalkinshaw
Copy link
Member

swalkinshaw commented Jan 7, 2017

Thanks for reporting this. I agree we should change it and looking back it wasn't a great idea :(

I'll switch it and try to figure out a migration path or some instructions.

swalkinshaw added a commit that referenced this issue Jan 7, 2017
@jvandijk
Copy link

jvandijk commented Jan 8, 2017

@lgarron Wow! Thank you for taking action on my feedback! And @swalkinshaw thumbs up for the fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants