Leverage browser caching / h5bp basic config

[strarsis]

Submit a feature request or bug report

• I've read the guidelines for Contributing to Roots Projects
• This is a feature request
• This is a bug report
• This request isn't a duplicate of an existing issue
• I've read the docs and followed them (if applicable)
• This is not a personal support request that should be posted on the Roots Discourse forums

---

Related to old PR discussion/comment #37 (comment) .

Google PageSpeed Insights recommends (and gives a higher score for)
leveraging browser caching, notably for static files.

Trellis already uses h5bp nginx server config and it also offers
basic configuration, useful for static files, notably expiry.

Note: Including this extra config can cause some side effects with the PHP related routing, see https://github.com/h5bp/server-configs-nginx/blob/master/doc/common-problems.md.

[swalkinshaw]

The original concern was that we can't guarantee assets that are included on a page contain cache busting information.

I guess if anyone uses the wp_enqueue methods, then they contain the version by default? Not entirely sure how trust worthy this is, or if we can assume people alway use those functions or some other method.

[mAAdhaTTah]

I guess if anyone uses the wp_enqueue methods, then they contain the version by default?

Yes, version of WP if nothing is set, otherwise the string provided to the version parameter.

[swalkinshaw]

Should be noted that anyone can add this config by using Nginx include/child templates.

[strarsis]

Are there any plans for adding this in near future? It is also a handy way improving the PageSpeed score.

[swalkinshaw]

Nope. My original concern still stands and this can easily be done by anyone that needs it.

[strarsis]

One way to solve this could be by using a plugin that enforces adding the necessary
cache busting parameter to all resources like Busted .

[swalkinshaw]

Seems useful but Trellis can't depend on a specific WP plugin.

[strarsis]

I agree with this and include the h5bp config file myself.