Use H5BP server configs

[austinpray]

This has been tested locally but I would like to try to deploy it on digital ocean to see if it runs alright on a remote server (shouldn't be an issue)

Any feedback on this?

---

Checks out a stable version of h5bp/server-configs-nginx and applies it
to the /etc/nginx folder

http://goo.gl/pBfB4W

Misc:
Adds "restart nginx" handler

closes #31

[swalkinshaw]

Since this isn't used I'm not sure we should include it by default yet.

This should ideally be identical to https://github.com/roots/bedrock-ansible/blob/master/roles/wordpress-sites/handlers/main.yml if we kept it in. Annoying that Ansible can't call handlers from another role.

[austinpray]

I'll remove it

[austinpray]

How about now?

[nathanielks]

Any votes against including h5bp/location/expires.conf as well? Will help with browser caching of static assets.

[austinpray]

If we enable caching wouldn't we need to implement some sort of revving process?

[nathanielks]

Aye. It's built in to WP's wp_enqueue_anything, though it adds a query string to the end of the file with the version number, which this guy recommends against. Wufoo proposed another solution.

Either way, by default we have a revving process built into WordPress. If we want to be more "legit," we could also look into implementing another solution.

[austinpray]

Provided we bake in the Wufoo solution by default I don't see a problem with it.

But enabling caching might have to be another issue separate from my basic integration PR here.

[nathanielks]

Totally agree. That'd be a great separate PR

[swalkinshaw]

Double quotes. Remember that you're the one who convinced me to switch :)

[austinpray]

( ͡° ͜ʖ ͡°)

[swalkinshaw]

Looks good other than the few minor formatting issues 👍

[austinpray]

Fixed the formatting issues. Thanks for keeping my ass in line ;).

[austinpray]

FYI: http://stackoverflow.com/questions/25576871/ansible-best-practice-to-copy-directories

[swalkinshaw]

I was going to comment about using copy then I looked up the docs, and yeah, only for local to remote. Linters are useful but only if they're correct!

[swalkinshaw]

One more thing. Can we add this? https://github.com/h5bp/server-configs-nginx/blob/master/sites-available/no-default. Something like:

- name: Enable better default site to drop unknown requests
  file: src=/tmp/server-configs-nginx/sites-available/no-default
        dest="/etc/nginx/sites-enabled/no-default.conf"
        owner=root
        group=root
        state=link

We may want to copy that file to sites-available before linking.

[austinpray]

Sure thing

[nathanielks]

Old issue in this thread, but worth bringing up again: completely forgot the Roots theme already has filename-based revving built in, so there's that.

[austinpray]

gonna add that thing @swalkinshaw requested tonight

[swalkinshaw]

@austinpray ^ 🐱

[austinpray]

Good to go.

[swalkinshaw]

Looks like you did a rebase of some sort but can this be squashed into 1 commit as well?

[austinpray]

welp. I think I borked it.

[austinpray]

okay fixed lol

[teohhanhui]

Would be good to have the expires issue sorted out... Is there any downside when including it?

[swalkinshaw]

@teohhanhui the downside is that you might not get the latest version of the files if you don't have cache busting in place. This comment still applies.