Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable subdomain multisite installations #116

Closed
wants to merge 3 commits into from

Conversation

nathanielks
Copy link
Contributor

Dropped dependency on vagrant-hostsupdater in favor of landrush. landrush spins up a small dns server that allows us to use wildcard subdomains, a requirement for subdomain multisite installs. Let me know what you think!

@@ -130,11 +129,27 @@ All Ansible configuration is done in [YAML](http://en.wikipedia.org/wiki/YAML).
* `wp_home` (required) - `WP_HOME` constant or `home` option (default: none)
* `wp_siteurl` (required) - `WP_SITEURL` constant or `siteurl` option (default: none)
* `wp_env` (required) - WordPress environment (default: none)
* `domain_current_site` (optional|required for multisite) - sets DOMAIN_CURRENT_SITE for multisite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backtick DOMAIN_CURRENT_SITE

@nathanielks
Copy link
Contributor Author

Also, a limitation to be aware of. vagrant reload sadly doesn't work with landrush. The only vagrant commands compatible are halt, destroy, and up. I've opened a ticket with them requesting reload support.

@nathanielks
Copy link
Contributor Author

Was researching other vagrant dns plugins and found that they all support *nix machines only. We'd have to figure out another solution if we want to include Windows support 😞. Thoughts?

@swalkinshaw
Copy link
Member

Finally getting back to this.

I'm thinking the best solution might just to be to keep the necessary subdomain changes but leave the hosts/DNS up to the user?

@nathanielks
Copy link
Contributor Author

mmm that could be a solid option. and maybe have landrush be an optional thing? "suggested default"?

@swalkinshaw
Copy link
Member

Yeah just add a note about it or they can always just manually add the hosts they need. Odds are it won't be many subdomains.

@nathanielks
Copy link
Contributor Author

👍

@retlehs
Copy link
Member

retlehs commented Apr 3, 2015

👀

@retlehs
Copy link
Member

retlehs commented Apr 3, 2015

@retlehs
Copy link
Member

retlehs commented Apr 7, 2015

see #168

@retlehs retlehs closed this Apr 7, 2015
@retlehs retlehs deleted the feature/multisite-subdomains branch April 7, 2015 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants