Reloading Nginx even if some Let's Encrypt certificates renewals has failed #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenoalvs
changed the title
|
Good idea 👍 Honestly I just default to using |
|
Leaving some credits to @viniciusrezende |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you can have just one or a few of your sites failing in the Let's Encrypt certificate renewal process.
When this occurs, if one of the others sites have its certificate renewed Nginx will not be reloaded which may break things.
This PR is a proposal to fix this issue by reloading Nginx anyways.
Another option could be modifying how the renewal script will terminate in these cases.
But I can't see any huge difference by doing this instead.