Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture and display all mail with MailHog in development #304

Merged
merged 1 commit into from
Aug 16, 2015
Merged

Capture and display all mail with MailHog in development #304

merged 1 commit into from
Aug 16, 2015

Conversation

louim
Copy link
Contributor

@louim louim commented Aug 16, 2015

This is a preliminary PR covering issue #298. There is a couple of things I'd like to address / get feedback on before considering it ready to be merged, but it's working great in its current form. See comments inline on the code.

@@ -1,4 +1,6 @@
mysql_root_password: devpw
mailhog_binary_url: https://github.com/mailhog/MailHog/releases/download/v0.1.7/MailHog_linux_amd64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be needed once geerlingguy/ansible-role-mailhog#6 is merged in.

@louim
Copy link
Contributor Author

louim commented Aug 16, 2015

Thanks to the speedy merge on the Mailhog Ansible role, the PR is now updated and ready to go. I added some information on the readme about how to access Mailhog in development. Feel free to find better wording to explain it! 👍

@swalkinshaw
Copy link
Member

Tested and working great. Want to squash?

Update mailhog to use the official repo and disable ferm for development
@louim
Copy link
Contributor Author

louim commented Aug 16, 2015

@swalkinshaw done!

swalkinshaw added a commit that referenced this pull request Aug 16, 2015
Capture and display all mail with MailHog in development
@swalkinshaw swalkinshaw merged commit aac04ef into roots:master Aug 16, 2015
@louim louim deleted the feature/catch-local-mail branch August 16, 2015 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants