Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about another bad characters in salts #484

Merged
merged 1 commit into from
Feb 21, 2016
Merged

Add note about another bad characters in salts #484

merged 1 commit into from
Feb 21, 2016

Conversation

dmgawel
Copy link
Contributor

@dmgawel dmgawel commented Feb 10, 2016

Characters {{ causes fail2ban error: fatal: [XXX.XXX.XXX.XXX] => Failed to template. I've added note about it.

@Foxaii
Copy link

Foxaii commented Feb 10, 2016

Thanks for highlighting this as it can definitely be clarified, but I don't think that your wording is any more correct.

These CANNOT contain the characters "{%" in succession
I believe this means that { and % cannot be doubled up i.e. {{ or %% will be parsed incorrectly.

Whereas your wording could be interpreted as you cannot have {% or {{ in succession i.e. {%{% or {{{{ or {%{{ or {{{% will be parsed incorrectly.

Whatever the note gets changed to should include examples, that way you can leave out the semantics.

@swalkinshaw
Copy link
Member

@Foxaii

I believe this means that { and % cannot be doubled up i.e. {{ or %% will be parsed incorrectly.

It's supposed to mean that {% can't appear exactly like that as a combination/group. %% shouldn't be a problem. {{ obviously would though.

swalkinshaw added a commit that referenced this pull request Feb 21, 2016
Add note about another bad characters in salts
@swalkinshaw swalkinshaw merged commit a2185e9 into roots:master Feb 21, 2016
@swalkinshaw
Copy link
Member

@dmgawel thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants