Add bun support #12
Merged
Add bun support #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megatux
force-pushed
the
issue-10__add_bun_support
branch
2 times, most recently
from
0251ed1
to
9cc1553
Compare
megatux
force-pushed
the
issue-10__add_bun_support
branch
from
9cc1553
to
3c02cda
Compare
blacksam07
requested changes
Nov 17, 2023
| else | ||
| create_file manifest, SPROCKETS_SETUP | ||
| end | ||
| add_to_manifest(manifest('app/javascript'), IMPORTMAP_SETUP) |
There was a problem hiding this comment.
Should be BUN_SETUP or we will use the same as importmap?
There was a problem hiding this comment.
I'll add a new constant
| @@ -11,7 +11,9 @@ class InstallGenerator < ::Rails::Generators::Base | |||
|
|
|||
| # Setup HTMX | |||
| def setup | |||
| if importmap? | |||
| if bun_configured? | |||
There was a problem hiding this comment.
To follow up the method naming style, can we rename to bun?
Co-authored-by: Julian Pasquale <julian.pasquale@rootstrap.com>
JulianPasquale
approved these changes
Nov 27, 2023
Right, seems related to this Truffleruby issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #10