Add mypy description to cookiecutter, deprecate circle ci #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jumcorredorro
commented
Jul 7, 2022
jumcorredorro
commented
- Add Mypy description to cookiecutter as a stage in pre-commit and github actions.
- Deprecate circle ci description
jumcorredorro
requested review from
a user,
MathiasLantean,
brunomichetti and
malexandroff1
python/cookiecutter-django.md
Outdated
| ### GitHub Workflow | ||
| 1. Create the path `.github/workflows` and inner it the file `python-app.yml` with the following content. |
Contributor
There was a problem hiding this comment.
Say that the file can have any name as long is in this folder
|
|
||
| ### [mypy](https://mypy.readthedocs.io/en/stable/) | ||
| *NOTE: By default, this package is already installed but it is NOT a stage added to pre-commit or Github Actions.* | ||
| Adding this typing hint check library to pre-commit or GitHub Workflow Actions is optional, it depends on your project scope. |
Contributor
There was a problem hiding this comment.
Make a reference to what you already wrote of typining
|
|
||
| </details> | ||
|
|
||
| If you want to check the Github Wokflow configuration please take a look at this [section](#github-workflow) |
Contributor
There was a problem hiding this comment.
Please also add an example of local execution of the command
brunomichetti
approved these changes
Jul 7, 2022
malexandroff1
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.