-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring the README #24
Comments
Also, I think this code chunk could point to # Let's use the package we just created.
install.packages("mtcars20_1.0.tar.gz", type = "source", repos = NULL)
library(mtcars20)
data("cars_over_20") # load the data
cars_over_20 # Now we can use it.
?cars_over_20 # See the documentation you wrote in data-raw/documentation.R. |
To be clear, the suggested structure in #24 (comment) is just meant to give you ideas, not force you into writing a certain way. You may also find it helpful to check out the official rOpenSci guidance on READMEs and this thread on vignette standards. |
You did a tone of work on the new README, and I really like it. It is neatly outlined and concise, and it operates at the right level of detail. Right under "Why package data sets?", would you consider adding an explicit definition of a data package? Maybe something like "A data package is a formal R package whose sole purpose is to contain, access, and/or document datasets." |
Glad to. Will be back in front of a computer by Monday, will deal with it then. |
- move YAML_CONFIG to vignettes. Issue #24 - Add definition of data package to README. Issue #25 - Move "R CMD build" to section after package_build is introduced. - Extend the "Purpose" section a bit. - Extended "Next Steps" and made it a sub-section. - Referenced "Happy Git and Github for the useR" and Hadley's book on R packages. - Fix typo mtcars2 to mtcars20
Very helpful, thank you. |
Currently, the
README
and vignette have almost identical content. I recommend diverging them becauseSuggested section outline
Suggested motivation section
I think it would be helpful to take a couple steps back here. Maybe it could flow like this:
datastorr
fst
Suggested minimal example
If you include the output of this code chunk, I would encourage suppressing the most verbose messages. For example, maybe set
quiet
toTRUE
inknit()
orrender()
.Consider
README.Rmd
It is becoming standard practice to generate the
README.md
from aREADME.Rmd
(example here). It is much easier this way to keep code chunk output synchronized with everything else.usethis::use_readme_rmd()
makes it easy.The text was updated successfully, but these errors were encountered: