Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace httr::GET() with httr::RETRY() #199

Closed
wants to merge 1 commit into from
Closed

replace httr::GET() with httr::RETRY() #199

wants to merge 1 commit into from

Conversation

annnvv
Copy link

@annnvv annnvv commented Apr 19, 2020

Thanks for this awesome project!

In this PR, I'd like to propose swapping out calls to httr::GET() etc. with httr::RETRY(). This will make the package more resilient to transient problems like brief network outages or periods where the service(s) it hits are overwhelmed. In my experience, using retry logic almost always improves the user experience with HTTP clients.

I'm working on chircollab/chircollab20#1 as part of Chicago R Collab, an R 'unconference' in Chicago.

@lbusett
Copy link
Contributor

lbusett commented Apr 19, 2020

@annnvv Thanks for the PR. Consider however that MODIStsp already uses a "retry" scheme based on a while loop (it is implemented like this because a different downloader can be also used, and that one can not use a RETRY)

@lbusett lbusett closed this Apr 19, 2020
@annnvv annnvv deleted the httr_retry branch April 19, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants