Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: Possibly add messy toggle to certain data types for the messy data use case #39

Closed
sckott opened this issue Mar 9, 2017 · 1 comment
Closed

review: Possibly add messy toggle to certain data types for the messy data use case #39

sckott opened this issue Mar 9, 2017 · 1 comment
Labels
later review
Milestone
v0.1

Comments

@sckott
Copy link
Collaborator

sckott commented Mar 9, 2017

Again, if this package is meant, at least as one use, to create "messy" data to use for function tests, it could be useful to introduce some variation in honorifics and degree listings (e.g., both "Mr" and "Mr.", both "PhD" and "Ph.D.") that might show up in real data.
@sckott sckott added the review label Mar 9, 2017
@sckott sckott mentioned this issue Mar 9, 2017
Closed
13 tasks
@sckott sckott added the later label Apr 19, 2017
sckott added a commit that referenced this issue May 28, 2017
@sckott
#39 implemented messy for just en_US for personprovider only
83ad846 
also added charlatan_settings fxn to set messy globally, but not used yet
bump dev version
sckott added a commit that referenced this issue May 28, 2017
@sckott
override local setting of messy in personprovider with global setting #…
8790b68 
…39
@sckott sckott mentioned this issue May 28, 2017
Open
@sckott
Copy link
Collaborator Author

sckott commented May 28, 2017

started this - close for review purpose, openining new issue to fill out more later: #41

@sckott sckott closed this as completed May 28, 2017
@sckott sckott modified the milestone: v0.1 May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
later review
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
1 participant
@sckott