Updates to ckan_fetch() and examples

[sharlagelfand]

A few changes to the functionality of ckan_fetch() and the functions it depends on:

• Uses sf::st_read() instead of the deprecatedmaptools::readShapePoints(), closes fetch() fails on SHP due to deprecated method in maptools #114
• Updated examples in ckan_fetch() due to http://publicdata.eu/ moving -- have changed them to some very 🇨🇦 centric ones!
• Allows reading and parsings of xlsx files (in addition to xls files already supported)
• (Some whitespace changes that just happen as a result of saving the file in RStudio -- not nitpicking your spaces!)

for the xlsx change, e.g. ckan_fetch() would return nothing with the current version ofckanr but works fine with the PR'd version:

library(ckanr)
#> Loading required package: DBI
ckanr_setup("https://ckan0.cf.opendata.inter.sandbox-toronto.ca")

res <- resource_show(id = "16772166-372d-422a-9bf0-a3d39c12d3a7", as = "table")

res$url
#> [1] "https://www.toronto.ca/ext/open_data/catalog/data_set_files/2017_Subway_Platform_Usage_Open_Data_Toronto.xlsx"

ckan_fetch(res$url)
#> New names:
#> * `` -> ...2
#> * `` -> ...3
#> * `` -> ...4
#> * `` -> ...5
#> * `` -> ...6
#> # A tibble: 79 x 6
#>    `Toronto Transit Commission`        ...2     ...3      ...4  ...5  ...6 
#>    <chr>                               <chr>    <chr>     <chr> <chr> <chr>
#>  1 Subway Station usage counts, 2017   <NA>     <NA>      <NA>  <NA>  <NA> 
#>  2 Showing number of customers travel… <NA>     <NA>      <NA>  <NA>  <NA> 
#>  3 <NA>                                <NA>     <NA>      <NA>  <NA>  <NA> 
#>  4 Rank, Total, of 74                  Station  Subway/R… To    From  Total
#>  5 1                                   BLOOR-Y… 1 Yonge-… 93924 1107… 2046…
#>  6 2                                   BLOOR-Y… 2 Bloor-… 96309 1001… 1964…
#>  7 3                                   UNION    1 Yonge-… 67881 60774 1286…
#>  8 4                                   ST. GEO… 1 Yonge-… 62131 64797 1269…
#>  9 5                                   ST. GEO… 2 Bloor-… 62668 62508 1251…
#> 10 6                                   FINCH    1 Yonge-… 43356 48707 92063
#> # … with 69 more rows

^{Created on 2019-06-26 by the reprex package (v0.2.1)}

I didn't see any existing tests for ckan_fetch(), read_session(), or fetch_GET() but please let me know if I missed them!

Also, please let me know if I should update the codemeta to reflect the removal of maptools and addition of sf -- I think yes but wasn't 100% sure! I'll do so if needed.

Thanks!

[sckott]

thanks @sharlagelfand having a look

[sckott]

• make sure to run document() or equiv. to update the manual file
• i badly need to add tests for this function - i'll do that soon, after this
• please do update codemeta

[sharlagelfand]

thanks! i've updated the codemeta using codemetar::write_codemeta(). I ran document() before and don't see any changes doing it again now.

[sckott]

thanks looks good