Skip to content

Commit

Permalink
added examples to legacy functions and ct_build_request, added contri…
Browse files Browse the repository at this point in the history
…buting file
  • Loading branch information
datapumpernickel committed Oct 14, 2023
1 parent 6f22ccd commit 406a084
Show file tree
Hide file tree
Showing 12 changed files with 147 additions and 0 deletions.
47 changes: 47 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Contributing to comtradr

This outlines how to propose a change to comtradr.
For more detailed info about contributing to this, and other tidyverse packages, please see the
[**development contributing guide**](https://rstd.io/tidy-contrib).

## Fixing typos

You can fix typos, spelling mistakes, or grammatical errors in the documentation directly using the GitHub web interface, as long as the changes are made in the _source_ file.
This generally means you'll need to edit [roxygen2 comments](https://roxygen2.r-lib.org/articles/roxygen2.html) in an `.R`, not a `.Rd` file.
You can find the `.R` file that generates the `.Rd` by reading the comment in the first line.

## Bigger changes

If you want to make a bigger change, it's a good idea to first file an issue and make sure someone from the team agrees that it’s needed.
If you’ve found a bug, please file an issue that illustrates the bug with a minimal
[reprex](https://www.tidyverse.org/help/#reprex) (this will also help you write a unit test, if needed).

### Pull request process

* Fork the package and clone onto your computer. If you haven't done this before, we recommend using `usethis::create_from_github("ropensci/comtradr", fork = TRUE)`.

* Install all development dependencies with `devtools::install_dev_deps()`, and then make sure the package passes R CMD check by running `devtools::check()`.
If R CMD check doesn't pass cleanly, it's a good idea to ask for help before continuing.
* Create a Git branch for your pull request (PR). We recommend using `usethis::pr_init("brief-description-of-change")`.

* Make your changes, commit to git, and then create a PR by running `usethis::pr_push()`, and following the prompts in your browser.
The title of your PR should briefly describe the change.
The body of your PR should contain `Fixes #issue-number`.

* For user-facing changes, add a bullet to the top of `NEWS.md` (i.e. just below the first header). Follow the style described in <https://style.tidyverse.org/news.html>.

### Code style

* New code should follow the tidyverse [style guide](https://style.tidyverse.org).
You can use the [styler](https://CRAN.R-project.org/package=styler) package to apply these styles, but please don't restyle code that has nothing to do with your PR.

* We use [roxygen2](https://cran.r-project.org/package=roxygen2), with [Markdown syntax](https://cran.r-project.org/web/packages/roxygen2/vignettes/rd-formatting.html), for documentation.

* We use [testthat](https://cran.r-project.org/package=testthat) for unit tests.
Contributions with test cases included are easier to accept.

## Code of Conduct

Please note that the comtradr project is released with a
[Contributor Code of Conduct](CODE_OF_CONDUCT.md). By contributing to this
project you agree to abide by its terms.
20 changes: 20 additions & 0 deletions R/ct_build_request.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,26 @@
#'
#' @param verbose whether the function sends status updates to the console
#'
#' @examplesIf interactive()
#' # Build request from checked parameters
#' ct_build_request(comtradr:::ct_check_params(type = 'goods',
#' frequency = 'A',
#' commodity_classification = 'HS',
#' commodity_code = 'TOTAL',
#' flow_direction = 'all',
#' reporter = 'all',
#' partner = 'World',
#' start_date = 2020,
#' end_date = 2022,
#' process = TRUE,
#' tidy_cols = TRUE,
#' verbose = FALSE,
#' primary_token = 'xxxx',
#' mode_of_transport = '0',
#' partner_2 = 'World',
#' customs_code ='C00',
#' update = FALSE ))
#'
#' @returns a httr2 request object
ct_build_request <- function(params,
primary_token = NULL,
Expand Down
18 changes: 18 additions & 0 deletions R/legacy.R
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
#' `r lifecycle::badge("superseded")`
#' @param ... Used to catch all possible arguments that users have supplied to this function.
#'
#' @examplesIf interactive()
#' # no examples because only legacy function
#'
#' @export
#' @returns depreciation error
ct_commodity_db_type <- function(...) {
Expand All @@ -15,6 +18,9 @@ ct_commodity_db_type <- function(...) {
#' `r lifecycle::badge("superseded")`
#'
#' @inheritParams ct_search
#' @examplesIf interactive()
#' # no examples because only legacy function
#'
#' @export
#' @returns depreciation error
ct_country_lookup <- function(...) {
Expand All @@ -26,6 +32,8 @@ ct_country_lookup <- function(...) {
#' @description This function is deprecated Please use `ct_get_data()` instead.
#' `r lifecycle::badge("superseded")`
#' @param ... Used to catch all possible arguments that users have supplied to this function.
#' @examplesIf interactive()
#' # no examples because only legacy function
#'
#' @export
#' @returns depreciation error
Expand All @@ -38,6 +46,8 @@ ct_search <- function(...) {
#' @title ct_update_databases
#' @description This function is deprecated. Please use `update` parameter in the main `ct_get_data` function instead.
#' `r lifecycle::badge("superseded")`
#' @examplesIf interactive()
#' # no examples because only legacy function
#'
#' @inheritParams ct_search
#' @export
Expand All @@ -50,6 +60,8 @@ ct_update_databases <- function(...) {
#' @title ct_use_pretty_cols
#' @description This function is deprecated. Please use the `process` argument in the main function instead.
#' `r lifecycle::badge("superseded")`
#' @examplesIf interactive()
#' # no examples because only legacy function
#'
#' @inheritParams ct_search
#' @export
Expand All @@ -62,6 +74,8 @@ ct_use_pretty_cols <- function(...) {
#' @title ct_get_reset_time
#' @description This function is deprecated. There is no more reset time, as the upper limit of 250 calls per day is enforced daily.
#' `r lifecycle::badge("superseded")`
#' @examplesIf interactive()
#' # no examples because only legacy function
#'
#' @inheritParams ct_search
#' @export
Expand All @@ -74,6 +88,8 @@ ct_get_reset_time <- function(...) {
#' @title ct_get_remaining_hourly_queries
#' @description This function is deprecated. There is no more reset time, as the upper limit of 250 calls per day is enforced daily.
#' `r lifecycle::badge("superseded")`
#' @examplesIf interactive()
#' # no examples because only legacy function
#'
#' @inheritParams ct_search
#' @export
Expand All @@ -86,6 +102,8 @@ ct_get_remaining_hourly_queries <- function(...) {
#' @title ct_register_token
#' @description This function is deprecated. Please use `set_primary_comtrade_key()` instead.
#' `r lifecycle::badge("superseded")`
#' @examplesIf interactive()
#' # no examples because only legacy function
#'
#' @inheritParams ct_search
#' @export
Expand Down
22 changes: 22 additions & 0 deletions man/ct_build_request.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions man/ct_commodity_db_type.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions man/ct_country_lookup.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions man/ct_get_remaining_hourly_queries.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions man/ct_get_reset_time.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions man/ct_register_token.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions man/ct_search.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions man/ct_update_databases.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions man/ct_use_pretty_cols.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 406a084

Please sign in to comment.