Skip to content

Commit

Permalink
update cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@datapumpernickel
datapumpernickel committed Sep 19, 2024
1 parent 74f469c commit f7d3626
Showing 1 changed file with 24 additions and 41 deletions.
65 changes: 24 additions & 41 deletions cran-comments.md
View file
Original file line number Diff line number Diff line change
@@ -1,49 +1,32 @@
## Patch for policy violation

* The package used rappdirs::user_cache_dir for determining the correct cache development. This has now been replaced with tools::R_user_dir('comtradr', which = 'cache').

* The package left a file that resulted from a faulty test in the cache directory.
This is not happening anymore.

#### Further comments

* I understand that the previous version created some additional files that were annoying to the CRAN team. Sorry about that. However, I would like to make a few comments that I think might enhance the process for future submitters. Please take these comments in the light of my relative ignorance concerning the underlying processes.

1) The documentation of `tools` is wrong. In the help page for the package it specifies `rappdirs` as a valid tool to specify cache directories. See: https://stat.ethz.ch/R-manual/R-patched/library/tools/html/userdir.html
This almost certainly will lead others astray.

--> Maybe you could use your authority as CRAN to let the R-Core Developers know that this is in fact wrong. I have already done the same for the people maintaining `rappdirs` and they have changed their documentation.

2) I do not exactly understand why the package was accepted previously. It adds to the mystery of CRAN that seemingly not all tests that could lead to the removal of a package are done all the time, but just sometimes. Now people have already adopted the package in a previous iteration (version 0.4.0) which also includes the "wrong" cache directory.

--> Is there a possibility to run tests that would trigger a removal **consistently** for all submissions?

3) Could it be advisable to restrict write-permissions for users on the CRAN servers? If packages are not allowed to write to the cache directory specified by rappdirs, maybe write-permissions could be restricted so that packages error out instead of creating clutter that the CRAN team has to sweep up after.

As per usual: Thanks for your work!
* this is a patch to fix two bugs in the package:
* a missing return in the call to tidy_cols did not allow users to set this argument to false, see https://github.com/ropensci/comtradr/issues/88
* a missing parameter in the file size conversion function did not allow the bulk facility to download small files. This has been fixed.

## Test environments

* local OS X x86_64-apple-darwin23.2.0(64-bit), R 4.3.3
* 1 🖥 linux R-* (any version) ubuntu-latest on GitHub
* 2 🖥 macos R-* (any version) macos-13 on GitHub
* 3 🖥 macos-arm64 R-* (any version) macos-latest on GitHub
* 4 🖥 windows R-* (any version) windows-latest on GitHub
* 5 🐋 atlas R-devel (2024-05-12 r86534) Fedora Linux 38 (Container Image)
* 6 🐋 clang-asan R-devel (2024-05-12 r86534) Ubuntu 22.04.4 LTS
* 7 🐋 clang16 R-devel (2024-05-11 r86532) Ubuntu 22.04.4 LTS
* 8 🐋 clang17 R-devel (2024-05-11 r86532) Ubuntu 22.04.4 LTS
* 9 🐋 clang18 R-devel (2024-05-11 r86532) Ubuntu 22.04.4 LTS
* 10 🐋 donttest R-devel (2024-05-11 r86532) Ubuntu 22.04.4 LTS
* 11 🐋 gcc13 R-devel (2024-05-12 r86534) Fedora Linux 38 (Container Image)
* 12 🐋 intel R-devel (2024-05-12 r86534) Fedora Linux 38 (Container Image)
* 13 🐋 mkl R-devel (2024-05-12 r86534) Fedora Linux 38 (Container Image)
* 14 🐋 nold R-devel (2024-05-12 r86534) Ubuntu 22.04.4 LTS
* 16 🐋 ubuntu-clang R-devel (2024-05-12 r86534) Ubuntu 22.04.4 LTS
* 17 🐋 ubuntu-gcc12 R-devel (2024-05-12 r86534) Ubuntu 22.04.4 LTS
* 18 🐋 ubuntu-next R-4.4.0 (patched) (2024-05-12 r86534) Ubuntu 22.04.4 LTS
* 19 🐋 ubuntu-release R-4.4.0 (2024-04-24) Ubuntu 22.04.4 LTS
* Windows Server 2022, R-devel, 64 bit
1 🖥 linux R-* (any version) ubuntu-latest on GitHub
2 🖥 macos R-* (any version) macos-13 on GitHub
3 🖥 macos-arm64 R-* (any version) macos-latest on GitHub
4 🖥 windows R-* (any version) windows-latest on GitHub
5 🐋 atlas R-devel (2024-09-18 r87177) Fedora Linux 38 (Container Image)
6 🐋 c23 R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS
7 🐋 clang-asan R-devel (2024-09-18 r87177) Ubuntu 22.04.5 LTS
8 🐋 clang16 R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS
9 🐋 clang17 R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS
10 🐋 clang18 R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS
11 🐋 clang19 R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS
12 🐋 donttest R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS
13 🐋 gcc13 R-devel (2024-09-18 r87177) Fedora Linux 38 (Container Image)
14 🐋 gcc14 R-devel (2024-09-18 r87177) Fedora Linux 40 (Container Image)
15 🐋 intel R-devel (2024-09-18 r87177) Fedora Linux 38 (Container Image)
16 🐋 mkl R-devel (2024-09-18 r87177) Fedora Linux 38 (Container Image)
17 🐋 nold R-devel (2024-09-18 r87177) Ubuntu 22.04.5 LTS
20 🐋 ubuntu-clang R-devel (2024-09-18 r87177) Ubuntu 22.04.5 LTS
21 🐋 ubuntu-gcc12 R-devel (2024-09-18 r87177) Ubuntu 22.04.5 LTS
22 🐋 ubuntu-next R-4.4.1 (patched) (2024-09-18 r87177) Ubuntu 22.04.5 LTS
23 🐋 ubuntu-release R-4.4.1 (2024-06-14) Ubuntu 22.04.5 LTS

## R CMD check results

Expand Down

0 comments on commit f7d3626

Please sign in to comment.