#128 have HttpRequest print update url when its been updated;

and work for handles as well which was broken

R/httprequest.R

@@ -79,8 +79,10 @@ HttpRequest <- R6::R6Class(
     #' @param ... ignored
     print = function(x, ...) {
       cat(paste0("<crul http request> ", self$method()), sep = "\n")
-      cat(paste0("  url: ", if (is.null(self$url))
-        self$handle$url else self$url), sep = "\n")
+      # cat(paste0("  url: ", if (is.null(self$url))
+      #   self$handle$url else self$url), sep = "\n")
+      cat(paste0("  url: ",
+        self$payload$url$url %||% self$handle$url %||% self$url), sep = "\n")
       cat("  curl options: ", sep = "\n")
       for (i in seq_along(self$opts)) {
         cat(sprintf("    %s: %s", names(self$opts)[i],
@@ -273,7 +275,7 @@ make_url_async <- function(url = NULL, handle = NULL, path, query) {
   url <- add_query(query, url)
 
   if (!is.null(handle)) {
-    curl::handle_setopt(handle, url = url)
+    curl::handle_setopt(handle$handle, url = url)
   } else {
     handle <- curl::new_handle(url = url)
   }

tests/testthat/test-request.R

@@ -81,6 +81,23 @@ test_that("HttpRequest - verb", {
   expect_error(HttpRequest$new(url = hb())$verb(5), "is not TRUE")
 })
 
+test_that("HttpRequest - prints new url after being modified", {
+  # query modifies url
+  aa <- HttpRequest$new(url = hb())
+  bb <- aa$get(query = list(foo = "bar", a = 5))
+  expect_output(print(aa), hb())
+  expect_output(print(bb), paste0(hb(), "\\?foo=bar&a=5"))
+
+  # handle passed in instead of a url
+  aa <- HttpRequest$new(handle = handle(file.path(hb(), "foobar")))
+  expect_output(print(aa), file.path(hb(), "foobar"))
+
+  # handle + query
+  aa <- HttpRequest$new(handle = handle(hb()))
+  bb <- aa$get(query = list(foo = "bar", a = 5))
+  expect_output(print(aa), hb())
+  expect_output(print(bb), paste0(hb(), "\\?foo=bar&a=5"))
+})
 
 test_that("HttpRequest fails well", {
   expect_error(HttpRequest$new(), "need one of url or handle")