Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream with async is broken with curl v3.3 #102

Closed
sckott opened this issue Jan 18, 2019 · 0 comments · Fixed by #103
Closed

stream with async is broken with curl v3.3 #102

sckott opened this issue Jan 18, 2019 · 0 comments · Fixed by #103
Labels
Milestone

Comments

@sckott
Copy link
Collaborator

sckott commented Jan 18, 2019

e.g.,

fun <- function(x) cat(rawToChar(x))
fun <- function(x) cat(rawToChar(x))
req1 <- HttpRequest$new(url = "https://httpbin.org/get"
    )$get(query = list(foo = "bar"), stream = fun)
req2 <- HttpRequest$new(url = "https://httpbin.org/get"
    )$get(query = list(hello = "world"), stream = fun)
out <- AsyncVaried$new(req1, req2)
out$request()
#> Error in (function (x)  : unused argument (0)
#> Error in (function (x)  : unused argument (1)

looks like he's changed the expected function structure expected passed to data param

@sckott sckott added the bug label Jan 18, 2019
@sckott sckott added this to the v0.8 milestone Jan 18, 2019
sckott added a commit that referenced this issue Jan 18, 2019
fix #101 add ability to pass opts, proxies, auth, and headers to Async initialize, new()
update tests for the changes
sckott added a commit that referenced this issue Jan 19, 2019
@sckott sckott mentioned this issue Feb 9, 2019
sckott added a commit that referenced this issue Feb 9, 2019
fix #101 add ability to pass opts, proxies, auth, and headers to Async initialize, new()
update tests for the changes
sckott added a commit that referenced this issue Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant