Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginator: support query params of page and per_page (or similar) #145

Closed
sckott opened this issue Sep 4, 2020 · 2 comments
Closed

Paginator: support query params of page and per_page (or similar) #145

sckott opened this issue Sep 4, 2020 · 2 comments
Labels
pagination
Milestone
v1.1

Comments

@sckott
Copy link
Collaborator

sckott commented Sep 4, 2020

by="query_params" supports limit/offset pagination approaches, but does not handle when you give a page number to get and an optional per_page or similar parameter for how many per page (similar to limit in the already supported approach)
@sckott
Copy link
Collaborator Author

sckott commented Sep 4, 2020 •
edited
Loading

use case sckott/discgolf#11

@sckott
Copy link
Collaborator Author

sckott commented Sep 4, 2020

related repo - using query_params https://github.com/bcgov/geometr/blob/ed19469f300ee343ff370a362a2d0b6142d321b1/R/geomet.R

@sckott sckott added this to the v1.1 milestone Sep 4, 2020
sckott added a commit that referenced this issue Sep 4, 2020
@sckott
#145 add page/per_page support to Paginator class
e4cdb3b
@sckott sckott mentioned this issue Sep 4, 2020
Closed
@sckott sckott closed this as completed Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pagination
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
1 participant
@sckott