Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async support #8

Closed
sckott opened this issue Nov 11, 2016 · 7 comments
Closed

Add async support #8

sckott opened this issue Nov 11, 2016 · 7 comments
Milestone
v0.3

Comments

@sckott
Copy link
Collaborator

sckott commented Nov 11, 2016

No description provided.

@sckott sckott added this to the v0.2 milestone Nov 11, 2016
@sckott sckott modified the milestones: v0.2, v0.3 Jan 2, 2017
sckott added a commit that referenced this issue Jan 12, 2017
@sckott
#8 started draft async - in a new separate R6 client for now
e2e6dac 
since interface is so different - and just GET for now, will add others later, should be straightforward
@sckott
Copy link
Collaborator Author

sckott commented Jan 12, 2017

started draft in branch async https://github.com/ropensci/crul/tree/async

@sckott
Copy link
Collaborator Author

sckott commented Feb 13, 2017

@artemklevtsov let me know what you think of the async interfaces on this branch https://github.com/ropensci/crul/tree/async

@artemklevtsov
Copy link

I think it's very interesting and useful. Also we need a some tests before merge with master.

@sckott
Copy link
Collaborator Author

sckott commented Feb 16, 2017 •
edited
Loading

  1. flowcharts of async vs synchronous like this one http://www.read.cs.ucla.edu/111/_media/notes/pipelining.jpg maybe you could add something similar to the README/vignette once you add async?
  2. being nice with the data provider.
  3. seealso for each async fxn

@artemklevtsov
Copy link

We can use https://httpbin.org/delay/1 to test async client.

@sckott
Copy link
Collaborator Author

sckott commented Feb 16, 2017

thx @artemklevtsov

@sckott
Copy link
Collaborator Author

sckott commented Feb 17, 2017

changes in 864d2b3 and 95e1deb

@sckott sckott closed this as completed in 8c4f07e Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
2 participants
@sckott @artemklevtsov