Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure connections are closed in examples, and possibly in pkg code #93

Closed
sckott opened this issue Oct 29, 2018 · 2 comments
Closed

make sure connections are closed in examples, and possibly in pkg code #93

sckott opened this issue Oct 29, 2018 · 2 comments
Milestone
v0.7

Comments

@sckott
Copy link
Collaborator

sckott commented Oct 29, 2018

in R-devel checks of examples

> base::assign(".dptime", (proc.time() - get(".ptime", pos = "CheckExEnv")), pos = "CheckExEnv")
> base::cat("writing-options", base::get(".format_ptime", pos = 'CheckExEnv')(get(".dptime", pos = "CheckExEnv")), "\n", file=base::get(".ExTimings", pos = 'CheckExEnv'), append=TRUE, sep="\t")
> ### * <FOOTER>
> ###
> cleanEx()
Error: connections left open:
	/tmp/RtmpC69h1s/file4d677f5c5a8e (file)
	/tmp/RtmpC69h1s/file4d6713233688 (file)
	/tmp/RtmpC69h1s/file4d67176cd3f (file)
	/tmp/RtmpC69h1s/file4d672f08c3d0 (file)
	/tmp/RtmpC69h1s/file4d6714e4317f (file)
	/tmp/RtmpC69h1s/file4d677f51d3df (file)
	/tmp/RtmpC69h1s/file4d674a74f666 (file)
Execution halted

looks like R-devel is maybe going to error if connections aren't closed
@hlapp hlapp mentioned this issue Dec 3, 2018
Merged
sckott pushed a commit that referenced this issue Dec 5, 2018
@hlapp @sckott
Removes possibilities for open connections ending up dangling
dd0698f 
Further addresses #93. Not clear whether this closes all such possibilities
because I cannot reproduce the issue reported on Travis for "R: devel",
and the dangling connections reported at the end of running devtools::test()
disappeared already after fdcafbf.
@hlapp
Copy link
Contributor

hlapp commented Dec 5, 2018

Can be closed now?

@sckott
Copy link
Collaborator Author

sckott commented Dec 5, 2018

yes, thanks

@sckott sckott closed this as completed Dec 5, 2018
@sckott sckott added this to the v0.7 milestone Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
2 participants
@hlapp @sckott