Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse binary done #116

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Parse binary done #116

merged 2 commits into from
Jul 30, 2019

Conversation

sckott
Copy link
Collaborator

@sckott sckott commented Jul 30, 2019

fix #115

@sckott
#115 fix for parse() in HttpResponse class
279c6bb 
fix parse for when binary file can not be converted to char with rawToChar
use tryCatch to try to parse, and on error, just give back raw
bump dev version
@sckott
revdep update
2bdc168
@sckott sckott added this to the v0.9 milestone Jul 30, 2019
@sckott sckott merged commit d8e220b into master Jul 30, 2019
@sckott sckott deleted the parse-binary branch July 30, 2019 15:22
@sckott sckott modified the milestones: v0.9, v0.8.4 Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.4
Development

Successfully merging this pull request may close these issues.

fix HttpResponse parse() method for binary files that dont convert raw->char
1 participant
@sckott