Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider SHA-256 as the default hash algorithm #117

Closed
cboettig opened this issue Aug 5, 2020 · 2 comments
Closed

Consider SHA-256 as the default hash algorithm #117

cboettig opened this issue Aug 5, 2020 · 2 comments
Labels
enhancement
Milestone
1.4.0

Comments

@cboettig
Copy link
Member

cboettig commented Aug 5, 2020

Creating a new DataObject generates an S4 object with a sysmeta field that uses SHA-1 as the checksum. SHA-256 might be a more collision-safe default these days.

new("DataObject", id, format="text/csv", filename=file)

Relatedly, it might be nice to let the user select the checksumAlgorithm, e.g.

new("DataObject", id, format="text/csv", filename=file, checksum = "SHA-256")
@mbjones
Copy link
Member

mbjones commented Aug 5, 2020

Based on our discussion, sounds great to me @cboettig. PR welcome, or we'll try to add this on our next release.

@mbjones mbjones modified the milestones: 1.3.3, 1.4.0 Aug 5, 2020
cboettig added a commit that referenced this issue Aug 5, 2020
@cboettig
sha1 -> sha256
e958e80 
addresses #117.  I think this is all that's needed?
@cboettig cboettig mentioned this issue Aug 5, 2020
Merged
@gothub gothub mentioned this issue Aug 7, 2020
Closed
gothub added a commit that referenced this issue Aug 26, 2020
@gothub
Use SHA-256 for new DataObjects/Sysmeta (#117)
9303c80
@gothub
Copy link
Contributor

gothub commented Aug 26, 2020 •
edited
Loading

SHA-256 is now the default for sysmeta/objects, updated in commits 9303c80 and ceef2d1

@gothub gothub closed this as completed Aug 26, 2020
gothub added a commit that referenced this issue Sep 30, 2020
@gothub
Use SHA-256 for new DataObjects/Sysmeta (#117)
996ba52
gothub added a commit that referenced this issue Sep 30, 2020
@gothub
Use SHA-256 for new DataObjects/Sysmeta (#117)
350b50e
gothub added a commit that referenced this issue Sep 30, 2020
@gothub
Add calculateChecksum (#117)
2e493a7
gothub added a commit that referenced this issue Sep 30, 2020
@gothub
Update DataObject unit test (#117)
773bd3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
3 participants
@cboettig @mbjones @gothub