-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest Rmd hunks approach for README&vignette? #159
Comments
I'm of mixed opinion on this. It needs more real-world testing. I suggest we wait a cycle or two and see how adoption of this or other similar workflows progresses. |
So should we even not suggest it at all in the guide? Cf phrasing in #161 |
I tweaked wording over in #161 |
Ok, I'll merge, and let this issue open. If we're lucky, by the end-of-the-year release we'll have learnt of other approaches / feedback on this approach. Many thanks @noamross! |
Should we actively ask feedback on the approach (via the forum/Slack) or look into recent repos to see whether anyone uses the approach? |
I'd ask if people do it, and see if there are common approaches. But I'm actually not sure this is going to have a lot of uptake, and that may be best. For instance, I think very few people use the |
Do you know the guide also mentions that |
|
Thanks, would you like to make a PR to the dev branch to add a link to this example? |
Thanks, @gadenbuie! I picked up a lot about templates from @alexpghayes while working on a broom PR. I think broom has a lot of powerful examples of using templates |
I've added suggestions and mentioned the downside. Thanks everyone! |
cf https://www.garrickadenbuie.com/blog/dry-vignette-and-readme/
The text was updated successfully, but these errors were encountered: