Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up manage_memory() #654

Closed
wlandau opened this issue Jan 6, 2019 · 1 comment
Closed

Speed up manage_memory() #654

wlandau opened this issue Jan 6, 2019 · 1 comment
Assignees
@wlandau
Labels
status: priority topic: performance
Milestone
Version 7.0.0

Comments

@wlandau
Copy link
Member

wlandau commented Jan 6, 2019

From #647, mange_memory() spends a ton of time on ls(). We should come up with something more efficient. Also, the function itself needs cleanup. We should have different functions for the different memory management strategies.
@wlandau wlandau self-assigned this Jan 6, 2019
@wlandau wlandau added this to the Version 7.0.0 milestone Jan 6, 2019
wlandau pushed a commit that referenced this issue Jan 7, 2019
@wlandau-lilly
Use names() instead of l() on environments where possible
c7d5167 
Related: #654. names() is faster.
@wlandau
Copy link
Member Author

wlandau commented Jan 7, 2019

I think c7d5167 fixed it. names() is much faster than ls(all.names = TRUE) for environments, and now the overhead in manage_memory() is insignificant when memory_strategy is "speed". In fact, all we see now is "mana..." on the far left.

screenshot_20190106_202016

@wlandau wlandau closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlandau wlandau

Labels
status: priority topic: performance
Projects
None yet
Milestone
Version 7.0.0
Development

No branches or pull requests
1 participant
@wlandau