Get rid of staged parallelism in make(parallelism = "mclapply") #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jobs were being forked, but they were erroring early.
Also spit out messages of mclapply failures
Would spawn 3 jobs
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
======================================
Coverage 100% 100%
======================================
Files 66 66
Lines 5331 5469 +138
======================================
+ Hits 5331 5469 +138
Continue to review full report at Codecov.
|
|
Tested on a couple different projects, seems to work fine. Let the beta testing begin! |
This was referenced May 2, 2018
|
Sounds like a good idea. I'm excited to test this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
make(parallelism = "mclapply", jobs = 2),drakespawns 2 persistent workers and a master process to govern them. This gets rid of staged parallelism for themclapplybackend. Other minor changes:mclapplytests on CRAN (would spawn 3 jobs).config$execution_graphtoconfig$scheduleinternally.All the unit tests seem to work, even for the "
local_mclapply_9" testing scenario, but there is some testing left to do on real projects.cc @krlmlr
GitHub issues fixed
This PR chips away at #369, but does not solve it. Many more to-do's remain in the checklist.
Checklist
drake's code of conduct, and I agree to follow its rules.testthatunit tests totests/testthatto confirm that any new features or functionality work correctly.devtools::check()