Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a use case for storing a data frame in a gist, #78 #79

Merged
merged 2 commits into from
Jul 18, 2019
Merged

add a use case for storing a data frame in a gist, #78 #79

merged 2 commits into from
Jul 18, 2019

Conversation

jsta
Copy link
Contributor

@jsta jsta commented Jul 14, 2019

See #78. I couldn't render the vignette as I was getting a Auth error on gist('7ddb9810fc99c84c65ec').

@sckott sckott added this to the v0.5 milestone Jul 17, 2019
Copy link
Contributor

@sckott sckott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! just a few small changes

gistr::gist_create(code = {
content$content
}, description = "using a gist as a data store",
filename = "iris.csv")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put in the output here? so readers can see what it should look like?

e.g. https://github.com/ropensci/gistr/blob/master/inst/vign/gistr_vignette.Rmd#L288-L293

text = gist(gists(what = "minepublic", per_page = 1)[[1]]$id)$
files$iris.csv$content)

identical(output, iris)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@jsta
Copy link
Contributor Author

jsta commented Jul 18, 2019

Good idea. Latest commit shows expected output.

@sckott
Copy link
Contributor

sckott commented Jul 18, 2019

thx, all looks good!

@sckott sckott merged commit 4319bce into ropensci:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants