Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize GHA workflow + update README + add Rproj #91

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

maelle
Copy link
Member

@maelle maelle commented Oct 18, 2022

Fix #89

Verified

This commit was signed with the committer’s verified signature.
maelle Maëlle Salmon
Copy link
Contributor

@ScientificProgrammer ScientificProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maelle:

I'm not familiar with this approach to CI/CD, but your changes look reasonable, and clearly, you know what you're doing. I'm going to go ahead and accept the changes. Then, I'll go back and review the usethis package and how best to use it with Github's triggered workflows. Thanks for your help!

Eric

@ScientificProgrammer ScientificProgrammer merged commit 61f2003 into master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants