Fixing images in inline chunks #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jeroen
force-pushed
the
master
branch
8 times, most recently
from
b5538f7
to
ba8ebea
Compare
jeroen
force-pushed
the
master
branch
3 times, most recently
from
88c7c7b
to
3f32278
Compare
jeroen
force-pushed
the
master
branch
2 times, most recently
from
fb75588
to
1312aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #310 this is an attempted fix for the issue. It works by distinguishing between the inline and regular chunk cases.
The inline solution is a bit hacky as the inline chunks are tracked by adding a
fig.inline.curoption to the global chunk options which is then incremented for each inline image.One additional issue is the possible collision between "inline-fig-*.ext" naming convention, this seems unlikely but maybe it would be better to create a separate inline folder within fig.path.