Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging dev into master #65

Merged
merged 16 commits into from
Dec 14, 2023
Merged

Merging dev into master #65

merged 16 commits into from
Dec 14, 2023

Conversation

BroVic
Copy link
Collaborator

@BroVic BroVic commented Dec 14, 2023

As part of the changes made upon migration of the package to rOpenSci, I have reflected this in the handling of codecov.io via changes in the GitHub Actions workflow file. Also, I have updated the codemeta.json file, although it did complain that the README URL could not be read. This is something I sill investigate a little further at a later time.

1. Update the package contributor metadata.
2. Force vignette builds during source installs from GitHub. Additionally, force installation of dependencies for `Imports` and `Suggests`.
3. Remove obsolete argument `fill` for `map_ng()` still found in the vignette.
4. Provided more clarity in the case where a geopolitical zone is passed to the `states` argument of `states()`. This now signals an error with information on how to use it correctly.

**Other Changes:**

- Improvements to function help.
The objects were not being retrieved from the global environment where they were created. This failure happened because the script is now being evaluated in a self-contained environment via `local()`.
Apart from some refactoring, one of the tests that kept producing a plot was identified and modified.
@BroVic BroVic merged commit c369550 into master Dec 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant