-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging dev into master #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update the package contributor metadata. 2. Force vignette builds during source installs from GitHub. Additionally, force installation of dependencies for `Imports` and `Suggests`. 3. Remove obsolete argument `fill` for `map_ng()` still found in the vignette. 4. Provided more clarity in the case where a geopolitical zone is passed to the `states` argument of `states()`. This now signals an error with information on how to use it correctly. **Other Changes:** - Improvements to function help.
The objects were not being retrieved from the global environment where they were created. This failure happened because the script is now being evaluated in a self-contained environment via `local()`.
Apart from some refactoring, one of the tests that kept producing a plot was identified and modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the changes made upon migration of the package to rOpenSci, I have reflected this in the handling of codecov.io via changes in the GitHub Actions workflow file. Also, I have updated the codemeta.json file, although it did complain that the README URL could not be read. This is something I sill investigate a little further at a later time.