Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namibia country code #24

Closed
knapply opened this issue Dec 16, 2017 · 2 comments · Fixed by #25
Closed

Namibia country code #24

knapply opened this issue Dec 16, 2017 · 2 comments · Fixed by #25

Comments

@knapply
Copy link

knapply commented Dec 16, 2017

I want to thank everyone who worked on this handy, dandy package that I've been playing with. So far it's an incredibly convenient way of dealing with messy addresses for which other solutions have been inadequate. I'm very grateful.

It's easy to work around, but as an FYI:
Namibia's country code is set to NA (as in not available) instead of the character "NA"

> opencage_forward(placename = "Windhoek,Namibia",  countrycode = "NA", no_annotations = TRUE)
# Error: countrycode does not have a valid value.

> opencage::countrycodes %>% filter(is.na(Code))
# # A tibble: 1 x 1
#    Code
#   <chr>
# 1  <NA>

@maelle
Copy link
Member

maelle commented Dec 21, 2017

Oops, thanks, will try to have a look ASAP!

dpprdan added a commit to dpprdan/opencage that referenced this issue Jan 8, 2018
maelle added a commit that referenced this issue Jan 16, 2018
Fix #24, limit NAs to empty strings
@maelle
Copy link
Member

maelle commented Jan 16, 2018

The new CRAN version fixes this thanks to @dpprdan! 🎉

maelle added a commit that referenced this issue Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants