Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crs #218

Closed
mpadge opened this issue May 23, 2020 · 2 comments
Closed

fix crs #218

mpadge opened this issue May 23, 2020 · 2 comments

Comments

@mpadge
Copy link
Member

mpadge commented May 23, 2020

sf has deprecated proj4string (here and here), so osmdata needs to reflect this. Current test-sf-construction all fail because of this.

mpadge added a commit that referenced this issue May 27, 2020
@mpadge
Copy link
Member Author

mpadge commented May 27, 2020

That just fixes the tests. The main C++ routines still use a hard-coded proj4string, which must be deprecated. However, doing this without importing sf will require hard-coding the WKT version, which is perhaps not the best approach? Not important for the moment, as sf will still accept proj4string values for the foreseeable future, but this will need to be addressed at some stage.

@mpadge mpadge closed this as completed in 4d7652e Mar 18, 2021
@mpadge
Copy link
Member Author

mpadge commented Mar 18, 2021

Needed to be done, as the proj4string deprecation notices form sf are now warnings which get propagated through to R CMD check results for packages using osmdata. That commit hard-codes the full WKT string, which seems to work seamlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant