Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] swap httr -> httr2 #272

Closed
mpadge opened this issue May 31, 2022 · 2 comments
Closed

[FEATURE] swap httr -> httr2 #272

mpadge opened this issue May 31, 2022 · 2 comments
Assignees
@mpadge
Labels
enhancement

Comments

@mpadge
Copy link
Member

mpadge commented May 31, 2022

No description provided.

@mpadge mpadge self-assigned this May 31, 2022
mpadge added a commit that referenced this issue Jun 1, 2022
@mpadge
swap httr -> httr2 for get_Features for #272
49e4c1b
mpadge added a commit that referenced this issue Jun 1, 2022
@mpadge
httr -> httr2 for getbb for #272
8828dcc
mpadge added a commit that referenced this issue Jun 1, 2022
@mpadge
httr -> httr2 for overpass_status for #272
c0d02d4
mpadge added a commit that referenced this issue Jun 1, 2022
@mpadge
httr -> httr2 for get_osmdata fns for #272
098ea9a
@mpadge
Copy link
Member Author

mpadge commented Jun 1, 2022

The commits above do all of the direct implementation. Now have to change the tests to use httptest2, and dump all of the former internal code for mocking test results.

mpadge added a commit that referenced this issue Jun 1, 2022
@mpadge
rm former stub.R file and authors thereof for #272
143905a
mpadge added a commit that referenced this issue Jun 1, 2022
@mpadge
clean namespace for #272
3894f33
mpadge added a commit that referenced this issue Jun 1, 2022
@mpadge
rm another mock results file for #272
2e699ca
mpadge added a commit that referenced this issue Jun 1, 2022
@mpadge
add test_elevation httptest2 files for #272
a973948
mpadge added a commit that referenced this issue Jun 1, 2022
@mpadge
httptest2 on test_features for #272
ac862b2
mpadge added a commit that referenced this issue Jun 1, 2022
@mpadge
nope, can't use httptest2 for #272 after all
894c5a8
mpadge added a commit that referenced this issue Jun 2, 2022
@mpadge
post-process httptest2 mock files for test_features for #272
7e0b8f6
mpadge added a commit that referenced this issue Jun 2, 2022
@mpadge
httptest2 mock test-elevation.R response for #272
ccb318c
mpadge added a commit that referenced this issue Jun 2, 2022
@mpadge
httptest2 mock test-getbb for #272
ef0adbf
mpadge added a commit that referenced this issue Jun 2, 2022
@mpadge
httptest2 mock test-osmdata for #272
13f8b4f
mpadge added a commit that referenced this issue Jun 2, 2022
@mpadge
httptest2 mock test-unname for #272
46915b6
mpadge added a commit that referenced this issue Jun 2, 2022
@mpadge
add httptest2 redactor for #272
4304dfb
mpadge added a commit that referenced this issue Jun 2, 2022
@mpadge
don't perform status queries in test envs for #272
e5189c0
mpadge added a commit that referenced this issue Jun 3, 2022
@mpadge
call set_overpass_url at start of each test for #272
0d64644
mpadge added a commit that referenced this issue Jun 3, 2022
@mpadge
reinstate mock files for #272
7aaed34
@mpadge
Copy link
Member Author

mpadge commented Jun 3, 2022

Finally done, after resolving issues with huge response file sizes, and eventually figuring out the overpass_url is selected using sample, so needs to be hard-coded in each test. All mock files now entirely reproducible, and only slightly larger than previous ones, but much easier to maintain courtesy of httptest2.

@mpadge mpadge closed this as completed Jun 3, 2022
@elipousson elipousson mentioned this issue Jun 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpadge mpadge

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpadge