You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of requiring the features parameter for add_osm_features() be provided with escape-formatted quotations, it would be great to support a named list. The following reprex shows how this could be added with a fairly minor change. Happy to open a pull request if you're interested!
Great idea @elipousson, a PR would be very welcome. I was never really happy with the whole escaped-quotes bagagge, but the annoyance level was only ever trivial, so i never did anything about it. Lists is a great solution, thanks! You'll just need to make sure all tests pass - ping me if you've got any questions.
- update add_osm_features per ropensci#277 includes adding a helper function set_bind_key_pre() to share handling of key_exact and value_exact w/ add_osm_feature
- add option to opq_osm_id to pass id w/ prefixed type, e.g. "relation/11158003"
- expand tests for add_osm_features() and opq_osm_id()
Instead of requiring the features parameter for
add_osm_features()
be provided with escape-formatted quotations, it would be great to support a named list. The following reprex shows how this could be added with a fairly minor change. Happy to open a pull request if you're interested!Created on 2022-11-09 with reprex v2.0.2
The text was updated successfully, but these errors were encountered: