Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add function to read .poly files #277

Closed
agila5 opened this issue Mar 7, 2023 · 3 comments · Fixed by #278
Closed

[FEATURE] Add function to read .poly files #277

agila5 opened this issue Mar 7, 2023 · 3 comments · Fixed by #278
Assignees
@agila5
Milestone
0.5.0

Comments

@agila5
Copy link
Contributor

agila5 commented Mar 7, 2023

See the title
@agila5 agila5 added this to the 0.5.0 milestone Mar 7, 2023
@agila5 agila5 self-assigned this Mar 7, 2023
@Robinlovelace
Copy link
Member

+1 to that. Worth a mini package? Possibly not...

@agila5
Copy link
Contributor Author

agila5 commented Mar 8, 2023

I'm not sure, it's literally just 1 function...

@Robinlovelace
Copy link
Member

Robinlovelace commented Mar 8, 2023 •
edited
Loading

1 function pkgs have been known. Would people who don't need all osmextract functionality and deps benefit? I guess so, but probably quickest to just add the function here. Can always split it out as a package later in the perhaps unlikely scenario that there is high demand for such a single-function pkg!

agila5 added a commit that referenced this issue Mar 8, 2023
@agila5
Add read_poly function + tests and docs
9ef8ace 
Fix #277
@agila5 agila5 linked a pull request Mar 8, 2023 that will close this issue
Add read poly #278
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agila5 agila5

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Add read poly ropensci/osmextract
2 participants
@Robinlovelace @agila5