Re-define provider argument in calling function

R/match.R

@@ -358,6 +358,14 @@ oe_match.character = function(
         quiet = quiet
       )
 
+      # If oe_match finds an exact match in one of the "other" providers and
+      # oe_match is called from another function (i.e. the parent.frame is not
+      # the global env), then we should also redefine the provider argument in
+      # the calling env. See https://github.com/ropensci/osmextract/issues/245
+      if (!identical(parent.frame(), .GlobalEnv)) {
+        assign("provider", other_provider, envir = parent.frame())
+      }
+
       return(
        oe_match(
          place = place,

tests/testthat/test-get.R

@@ -28,3 +28,16 @@ test_that("We can specify path using ~", {
   )
   unlink("~/test_for_tilde_in_R_osmextract", recursive = TRUE)
 })
+
+test_that("The provider is overwritten when oe_match find a different provider", {
+  # See https://github.com/ropensci/osmextract/issues/245
+  skip_on_cran()
+  skip_if_offline("github.com")
+
+  expect_match(
+    oe_get("Canarias", download_only = TRUE, skip_vectortranslate = TRUE, quiet = TRUE, download_directory = tempdir()),
+    regexp = "openstreetmap_fr"
+  )
+  file.remove(list.files(tempdir(), pattern = "pbf", full.names = TRUE))
+})
+

tests/testthat/test-match.R

@@ -161,3 +161,8 @@ test_that("oe_match returns a warning message with missing CRS in input place",
     "The input place has no CRS, setting crs = 4326."
   )
 })
+
+test_that("oe_match does not create a variable in global env after https://github.com/ropensci/osmextract/pull/246", {
+  oe_match("Leeds")
+  expect_false(exists("provider", where = .GlobalEnv))
+})