Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when downloading/pulling older versions of files #8

Closed
mpadge opened this issue Jul 4, 2018 · 3 comments
Closed

Warn when downloading/pulling older versions of files #8

mpadge opened this issue Jul 4, 2018 · 3 comments

Comments

@mpadge
Copy link
Member

mpadge commented Jul 4, 2018

With respectful acknowledgment of your mistrust of timestamps, one place where these would actually be useful would be in order to implement a warning when downloading/pulling older versions of files, and consequently overwriting newer versions that may have since been created locally. That would be a really useful safety mechanism (for my current workflow at least). We're throwing files between lots of different people doing different tasks, and inadvertent overwrites do happen, and are potentially painful.

@cboettig
Copy link
Member

cboettig commented Jul 4, 2018

Yeah, overwrites are definitely and issue so that's a good idea.

Maybe we should go one further and simply provide the option of use_timestamps = FALSE/warn,/TRUE to push/pull. warn would do as you say, FALSE is the current behavior, and TRUE would only push/pull those files with differing hashes AND older timestamps.

Perhaps my mistrust of timestamps is not so warranted -- mostly arises from the fact that switching branches changes the timestamp, and from work on poorly maintained servers with drifting clocks long ago. I guess since these files are not git managed, they would not be impacted by the latter. A more empirically grounded opinion on timestamps might be called for. (I agree that managing the hash tree a la git is the 'real' solution to version tracking, but I'm not going to implement that by hand).

@mpadge
Copy link
Member Author

mpadge commented Jul 4, 2018

That sounds like a great solution. And yeah, the whole idea of piggyback is to avoid clogging up repos with the piggybacked files, so one can surely assume they very generally won't be part of a git tree, so should not have time stamps altered by any git operations. This would - for me - be a great boost!

cboettig added a commit that referenced this issue Jul 20, 2018
using timestamps is now the default for upload/download, but not for push/pull.
@cboettig
Copy link
Member

cboettig commented Sep 4, 2018

timestamp behavior now the default for upload / download

@cboettig cboettig closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants