Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in auth header #79

Merged
merged 4 commits into from
Jul 6, 2022
Merged

fix bug in auth header #79

merged 4 commits into from
Jul 6, 2022

Conversation

tanho63
Copy link
Collaborator

@tanho63 tanho63 commented Jul 1, 2022

Introduced a bug because I forgot to use Authorization in the header. Probably should have a better look at all the tests before next CRAN release

@tanho63
Copy link
Collaborator Author

tanho63 commented Jul 1, 2022

Hmm. I wonder if that check failure is just a bad API response. It would help if the error message returned the HTTP code...

Copy link
Member

@cboettig cboettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for all the continued work here. Can you also switch your role from ctb to aut and list your name second in the Authors@R list?

@cboettig
Copy link
Member

cboettig commented Jul 6, 2022

🚀

@cboettig cboettig merged commit 4c22982 into ropensci:master Jul 6, 2022
@cboettig
Copy link
Member

cboettig commented Jul 6, 2022

(apologies for the delay, was away from 💻 for a bit)

@tanho63 tanho63 deleted the fix/authheader branch July 7, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants