Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restricts calls to sf #89

Merged
merged 8 commits into from
Sep 4, 2019
Merged

Restricts calls to sf #89

merged 8 commits into from
Sep 4, 2019

Conversation

KevCaz
Copy link
Member

@KevCaz KevCaz commented Sep 4, 2019

This PR restricts calls to sf features to:

  • search_networks_sf()
  • get_collection() get_network_by_id_indiv() and get_network_by_id when argument as_sf is set to TRUE

Consequently, mgSearchInteractions objects are no longer sf objects. Similarly, mgSearchNetworks are no longer sf objects unless search_networks_sf() has been used.

This is now documented.

@KevCaz KevCaz added enhancement New feature or request rOpenSci - review Adress reviewers comments labels Sep 4, 2019
@KevCaz KevCaz merged commit b55342e into master Sep 4, 2019
@KevCaz
Copy link
Member Author

KevCaz commented Sep 4, 2019

ropensci/software-review#332

@SteveViss SteveViss mentioned this pull request Sep 5, 2019
Closed
25 tasks
@SteveViss SteveViss deleted the nosf branch March 28, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request rOpenSci - review Adress reviewers comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KevCaz