Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put code initial vignette into repo #23

Closed
fmichonneau opened this issue Jun 12, 2015 · 4 comments
Closed

put code initial vignette into repo #23

fmichonneau opened this issue Jun 12, 2015 · 4 comments

Comments

@fmichonneau
Copy link
Member

@dwinter it would be great to have your blue fish red fish vignette in the repo.

I'm running out of time today to do it and don't want to forget, but feel free to push it if you have time.

@dwinter
Copy link
Member

dwinter commented Jun 20, 2015

Will try and get this done today @fmichonneau, shall I add it to the existing vignette (under a new heading)?

Might take a little while as the example in the original one doesn't seem to work anymore...

@fmichonneau
Copy link
Member Author

I was initially thinking of having it as a separate vignette, but I think it would be fine as new heading in the existing one.

Don't spend too much time on it if it doesn't work anymore. It would just be nice to have something that shows how to include the results from OTL with data from other public sources.

Thanks!

@dwinter
Copy link
Member

dwinter commented Jun 21, 2015

OK, I'll see if I can cook up a new example, because it looks like the problem with the old one is on the OpenTree side OpenTreeOfLife/oti#41

dwinter added a commit that referenced this issue Jun 22, 2015
This needs more work!

It's really too long to include in this existing vignette, and the text
accompanying the code needs to improve.

I think it is going to be hard to make a "snappy" summary with this
tree, it's just so big and there are so few coloured fish! I will keep
working on this branch until I come up with something worth adding to
the repo.
dwinter added a commit that referenced this issue Jul 9, 2015
Idea is just to show a simple workflow, and some of the
steps usually needed to join up tips (here as a `phylo4d`
object).

Need to work on the text still, but think this will be the basis of the
vignette
@fmichonneau
Copy link
Member Author

New vignette is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants