Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work on acknowledging post editors #765

Merged
merged 3 commits into from
May 24, 2024
Merged

work on acknowledging post editors #765

merged 3 commits into from
May 24, 2024

Conversation

maelle
Copy link
Member

@maelle maelle commented May 21, 2024

Examples:

Questions

  • Does it look good?
  • How do we backfill the editor field of older posts?
  • Should we later consider adding a list of posts edited by a person, on that person's author page?
  • This won't appear on R Bloggers and Rogue Scholar as far as I know. I could ask Rogue Scholar what the field for editors could be.

@steffilazerte
Copy link
Member

I think it looks good! What do we do if someone is an editor and an author? I think it would just be authors then (no editor), with the implication that the authors edited the post collectively.

Back filling will be difficult! I think we'd have to look at the pull request histories or perhaps contributions? We could write a script but that might be overkill. Perhaps I can just peg away a bit at it and we add them as we can?

I'm not sure about adding the editors to the author page. It's nice, but perhaps overkill?

@yabellini
Copy link
Member

I also think it looks good. :-)
About listing the edition on the author page is a good idea. I would have different listings. First, all the articles that you are the author, and then all the articles that you are the editor. The list will be long for rOpenSci staff (current and former); I don't think it will be long for other people, right?

@maelle
Copy link
Member Author

maelle commented May 24, 2024

I opened #766, it could happen later.

@maelle
Copy link
Member Author

maelle commented May 24, 2024

Note that for newsletter posts, since the author is The rOpenSci Team, I won't list editors.

@maelle maelle marked this pull request as ready for review May 24, 2024 07:27
@maelle
Copy link
Member Author

maelle commented May 24, 2024

I added editors for this year's post. Good enough for now :-)

@maelle maelle merged commit 2460a65 into main May 24, 2024
4 checks passed
@maelle maelle deleted the editor branch May 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants