Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve socket options #49

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

mschubert
Copy link
Contributor

  • Remove ZeroMQ<3 code, this will never be compiled due to static version assert >= 3
  • Replace redundant option setting functions by setSockOptChr and setSockOptInt
  • Expose high water mark option for ZeroMQ>=3 using set.send.hwm and set.rcv.hwm
  • Include TCP keep-alive options supported by ZeroMQ>=3 using set.tcp.keepalive

@codecov-io
Copy link

codecov-io commented Jan 1, 2019

Codecov Report

Merging #49 into master will increase coverage by 2.88%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #49      +/-   ##
=========================================
+ Coverage   33.72%   36.6%   +2.88%     
=========================================
  Files           4       4              
  Lines         685     631      -54     
=========================================
  Hits          231     231              
+ Misses        454     400      -54
Impacted Files Coverage Δ
src/interface.cpp 31.68% <0%> (+2.97%) ⬆️
R/rzmq.R 23.21% <0%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1779cf...50d4165. Read the comment docs.

@jeroen jeroen requested a review from armstrtw February 24, 2019 17:17
@bicarlsen bicarlsen mentioned this pull request Apr 24, 2023
@jeroen jeroen force-pushed the master branch 2 times, most recently from 8ff7ca8 to 9795f9b Compare May 8, 2023 10:09
@jeroen jeroen force-pushed the master branch 3 times, most recently from de16540 to 0711fad Compare September 25, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants