Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture and give back to users any error messages #189

Closed
sckott opened this issue Jun 7, 2018 · 1 comment
Closed

Capture and give back to users any error messages #189

sckott opened this issue Jun 7, 2018 · 1 comment
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Jun 7, 2018

either client or server errors, and give back in meta slot

e..g, GBIF gives an error of Error: Points of LinearRing do not form a closed linestring with:

occ_search(scientificName= 'Anopheles arabiensis', 
    geometry =  'POLYGON((42.0 -26.0, 52.0 -26.0, 52.0 -13.0, 42.0 -13.0))',
    curlopts = list(verbose=TRUE), 
    skip_validate=TRUE)

but in spocc we pass skip validate so then GBIF handles any bad WKT, like

occ(query = 'Anopheles arabiensis', 
    geometry =  'POLYGON((42.0 -26.0, 52.0 -26.0, 52.0 -13.0, 42.0 -13.0))', 
    callopts = list(verbose =TRUE))
@sckott sckott added this to the v0.8 milestone Jun 7, 2018
sckott added a commit that referenced this issue Jun 9, 2018
@sckott sckott modified the milestones: v0.8, v0.9 Jul 3, 2018
@sckott
Copy link
Contributor Author

sckott commented Oct 16, 2018

In addition to any error that occurs - perhaps capture and give back the http request that was sent with each request, so that upon errors, user can inspect the requests to pull out if the request they thought was being sent was actually sent. not sure if its best to just give url or complete http response or something else

sckott added a commit that referenced this issue Nov 14, 2018
…thers still

changes in occ() to accomodate error reproting
#189
@sckott sckott closed this as completed in 15f686b Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant