Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #132 #159

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Close #132 #159

merged 2 commits into from
Feb 25, 2020

Conversation

Robinlovelace
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 25, 2020 •
edited
Loading

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   71.91%   71.91%           
=======================================
  Files           7        7           
  Lines         445      445           
=======================================
  Hits          320      320           
  Misses        125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe420d5...1e175a4. Read the comment docs.

@Robinlovelace Robinlovelace mentioned this pull request Feb 25, 2020
Closed
@Robinlovelace Robinlovelace requested a review from agila5 February 25, 2020 12:42
@Robinlovelace
Copy link
Member Author

Please review and merge if happy @layik.

@Robinlovelace Robinlovelace requested a review from layik February 25, 2020 12:43
agila5
agila5 approved these changes Feb 25, 2020
View reviewed changes
Copy link
Collaborator

@agila5 agila5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

layik
layik approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@layik layik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 GitHub kept crashing earlier today.

@layik layik merged commit f7ef166 into master Feb 25, 2020
@Robinlovelace Robinlovelace deleted the logo branch February 25, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agila5 agila5 agila5 approved these changes

@layik layik layik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Robinlovelace @codecov-io @layik @agila5