Use old readr on windows #206
Conversation
|
Tests have passed 🎉 Just one note: I decided to adopt edition 1 only on windows since the
This implies that the user gets slightly different results depending on the OS but, I think, the benefits of the new |
|
Looks great to me and +1 for using the newer and faster approach where possible. |
| @@ -120,10 +120,10 @@ dl_stats19 = function(year = NULL, | |||
| utils::download.file(zip_url, destfile = destfile, quiet = silent) | |||
| } | |||
| if(is_zip_file) { | |||
| f = file.path(destfile, utils::unzip(destfile, list = TRUE)$Name) | |||
| f2 = file.path(destfile, utils::unzip(destfile, list = TRUE)$Name) | |||
There was a problem hiding this comment.
Reasonable object renaming, sorry for the terse object names, and having thought about it more explicit and longer names would probably better - only issue being when you go over 80 characters on a line. FYI this would not be allowed if we used Rust and the clippy code checking tool. Heads up @dabreegster in case it's of interest, this is deep in the codebase that downloads, reads and cleans the STATS19 crash data for the UK.
| @@ -27,6 +27,12 @@ read_accidents = function(year = NULL, | |||
| data_dir = get_data_directory(), | |||
| format = TRUE, | |||
| silent = FALSE) { | |||
| # Set the local edition for readr. | |||
| # See https://github.com/ropensci/stats19/issues/205 | |||
| if (.Platform$OS.type == "windows" && utils::packageVersion("readr") >= "2.0.0") { | |||
There was a problem hiding this comment.
Minimising the impact of the change 👍
TODO, just want to test the GHA. Will fix #205.