Refactor use_tic()
#193
Merged
Refactor use_tic()
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
krlmlr
approved these changes
Oct 31, 2019
| @@ -11,7 +11,6 @@ before_install: | |||
| - R -q -e 'remotes::install_local(getwd(), force = TRUE); print(tic::dsl_load()); tic::prepare_all_stages()' | |||
| - R -q -e 'tic::before_install()' | |||
| install: R -q -e 'tic::install()' | |||
| after_install: R -q -e 'tic::after_install()' | |||
There was a problem hiding this comment.
This stage is not supported (anymore) by Travis. Discovered this by running the official Travis lintr.
There was a problem hiding this comment.
Maintaining multiple .yml templates for each CI platform seems like a nightmare in the long run. Is there any chance to generalize this?
We could trim it down to one file for "build", "deploy" and "meta" (matrix, libs) and cat them together when building the template. This way, we would only have to maintain three files at max per CI provider.
krlmlr
approved these changes
Nov 7, 2019
| @@ -11,7 +11,6 @@ before_install: | |||
| - R -q -e 'remotes::install_local(getwd(), force = TRUE); print(tic::dsl_load()); tic::prepare_all_stages()' | |||
| - R -q -e 'tic::before_install()' | |||
| install: R -q -e 'tic::install()' | |||
| after_install: R -q -e 'tic::after_install()' | |||
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add new templates: Asks the user what to build (single/matrix, Linux/macOS), which CI provider to use at all and if multiple R versions are desired
Update templates
move some functions to their own .R file to clean up a bit
update vignette
use the cli package (dev version) for more sophisticated cli output
removes the
after_installstage as this stage is deprecated by Travisadds some info to the tic.R template
update badges
export
use_*_yml()functions so that users can install yml templates withoutuse_tic()