Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for new 'Get started' vignette #63

Merged
merged 40 commits into from
Aug 13, 2018
Merged

Draft for new 'Get started' vignette #63

merged 40 commits into from
Aug 13, 2018

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Jun 28, 2018

Addresses #57, not fully ready yet but merging anyway.

@codecov-io
Copy link

codecov-io commented Jun 28, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@d5231a2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #63   +/-   ##
=========================================
  Coverage          ?   63.54%           
=========================================
  Files             ?       19           
  Lines             ?      502           
  Branches          ?        0           
=========================================
  Hits              ?      319           
  Misses            ?      183           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5231a2...5141a21. Read the comment docs.

@maelle
Copy link
Member

maelle commented Jun 28, 2018

Do you deploy the pkgdown website yourself, not by Travis? 😮

@maelle
Copy link
Member

maelle commented Jun 28, 2018

Reg vignettes vs README you might find the discussion in ropensci/software-review-meta#55 interesting (and don't hesitate to chime in there!)

@krlmlr
Copy link
Collaborator Author

krlmlr commented Jun 28, 2018

Thanks for the pointer, I'll take a look.

668a4bf happened automatically, but to preview it we'd need Netlify. I can't add this repo to Netlify, who could give Netlify the necessary permissions?

@maelle
Copy link
Member

maelle commented Jun 28, 2018

Ah that'd be so cool, I was wishing it'd include a preview.

Not sure, not me at least, will ask.

@krlmlr krlmlr mentioned this pull request Jul 30, 2018
@krlmlr krlmlr merged commit 4b53680 into master Aug 13, 2018
@krlmlr
Copy link
Collaborator Author

krlmlr commented Aug 13, 2018

Merging now, let's continue discussion in #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants