Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response to reviewers #5

Merged
merged 12 commits into from
Apr 29, 2022
Merged

Response to reviewers #5

merged 12 commits into from
Apr 29, 2022

Commits on Apr 26, 2022

  1. Don't pre-emptively escape unity

    @mikemahoney218
    mikemahoney218 committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    128714f View commit details
    Browse the repository at this point in the history

  2. Handle non-local terrain (fixes #6)

    @mikemahoney218
    mikemahoney218 committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    bfbb306 View commit details
    Browse the repository at this point in the history

  3. Update test

    @mikemahoney218
    mikemahoney218 committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    ed6fe1e View commit details
    Browse the repository at this point in the history

  4. Fix examples (fixes #8)

    @mikemahoney218
    mikemahoney218 committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    1d5b1fe View commit details
    Browse the repository at this point in the history

  5. Address most reviewer comments

    @mikemahoney218
    mikemahoney218 committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    01e6b05 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Rotate trees correctly if not specified

    @mikemahoney218
    mikemahoney218 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    1e2b056 View commit details
    Browse the repository at this point in the history

  2. Update vignette

    @mikemahoney218
    mikemahoney218 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    bb1c218 View commit details
    Browse the repository at this point in the history

  3. Bump version, add NEWS

    @mikemahoney218
    mikemahoney218 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    9ee7e59 View commit details
    Browse the repository at this point in the history

  4. Remove unused NEWS sections

    @mikemahoney218
    mikemahoney218 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    3d409d0 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Will Jones <willjones127@gmail.com>
    @mikemahoney218 @wjones127
    mikemahoney218 and wjones127 authored Apr 29, 2022
    Configuration menu
    Copy the full SHA
    76d8912 View commit details
    Browse the repository at this point in the history

  2. Note file format

    @mikemahoney218
    mikemahoney218 committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    3db10a7 View commit details
    Browse the repository at this point in the history

  3. Acknowledge reviewers & update codemeta

    @mikemahoney218
    mikemahoney218 committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    0944e1f View commit details
    Browse the repository at this point in the history