Maybe change suggested use_cassette usage?

[sckott]

I have been doing (assume the expect_is call fails)

test_that("foobar works", {
    vcr::use_cassette("foobar", {
        a <- foobar()
        expect_is(a, "character")
    })
})

But when the expect_is line fails, the traceback gives the line for the vcr::use_cassette call, instead of the expect_is line.

if we change to:

vcr::use_cassette("foobar", {
  test_that("foobar works", {
      a <- foobar()
      expect_is(a, "character")
  })
})

the traceback points to the actual test line that failed

---

Make sure this doesn't lead to othe problems

[dpprdan]

Wouldn't this also be an option?

test_that("foobar works", {
    vcr::use_cassette("foobar", {
        a <- foobar()
    })
    expect_is(a, "character")
})

Or rather, is there a problem with it, I am not seeing ATM? Traceback seems to work with it.

[sckott]

You're right. Thanks for the ping on this. I'll add to the docs the various ways you can arrange the code blocks and test lines

[sckott]

https://github.com/ropensci/vcr#best-practices