Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

started design vignette #233

Merged
merged 3 commits into from
May 4, 2021
Merged

started design vignette #233

merged 3 commits into from
May 4, 2021

Conversation

sckott
Copy link
Collaborator

@sckott sckott commented Mar 18, 2021

Design chapter, via ropensci-books/http-testing#30

Probably some other things could be included, but I think this is a good first pass

#232

@sckott sckott added the docs label Mar 18, 2021
@sckott sckott requested a review from maelle March 18, 2021 19:47
Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, super interesting! I added a few comments.

Once this is merged (not urgent) could you make a PR to the book repo?

man/rmdhunks/vcr-design.Rmd Show resolved Hide resolved
man/rmdhunks/vcr-design.Rmd Outdated Show resolved Hide resolved
man/rmdhunks/vcr-design.Rmd Outdated Show resolved Hide resolved
man/rmdhunks/vcr-design.Rmd Show resolved Hide resolved
man/rmdhunks/vcr-design.Rmd Outdated Show resolved Hide resolved
man/rmdhunks/vcr-design.Rmd Outdated Show resolved Hide resolved
man/rmdhunks/vcr-design.Rmd Show resolved Hide resolved
man/rmdhunks/vcr-design.Rmd Show resolved Hide resolved
man/rmdhunks/vcr-design.Rmd Outdated Show resolved Hide resolved
sckott and others added 2 commits May 4, 2021 16:17
@sckott sckott added this to the v0.7 milestone May 4, 2021
@sckott sckott merged commit a874e5f into master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants