Does not work with uncommon netmasks

[sindastra]

I am in a /16 network, but inside the app it defaults to /24, meaning it won't scan the entire network.

I went into my WiFi settings inside Android and manually set a static address with a 16 bit netmask to be absolutely sure Android knows it's a 16 bit netmask. After the change, the address displayed inside the app updated, but the netmask remained /24 which leads me to believe it's an issue with the app.

Unless of course, Android returns a wrong netmask.

Edit:

I am aware that 2^16 would mean it scans for 65,536 potential devices, which might be a little bit too much.

Maybe add an additional option to scan for an address range instead of the entire network?

But of course that should be fully optional, and default to scanning the entire network, as typing in a range each time could get annoying quite quickly! 😄

Also, someone that wants to actually scan a network might not know how many devices there are, or where they are, and would likely want to scan it all. So maybe add a warning that such a scan might take some time?

[rorist]

Hello,

The app is trying to get the net mast in here:

android-network-discovery/src/info/lamatricexiste/network/Network/NetInfo.java

Line 114 in 6271c14

private void getCidr() {

If everything fails, it uses /24. I guess those commands are not working in current versions of Android

[sindastra]

Hello and thanks! I took a look and forked the repo now.

Once I get home later I'll fix it and create a pull request.

I am running stock Android 6.0.1 and the binary is still there, just at a different location. I will of course make a fix with backwards compatibility.

I will then also take a look and test it on vanilla Android N (AOSP 7) in a virtual machine once home.

There is of course a possibility that it's just my manufacturer that put things in different places, we'll see.

[rorist]

Well, the version in github is ahead of the version on the play store. I
think it's a little bit different in master, but feel free to play with it !

Regards

Le 10/18/2016 à 04:03 PM, Nat a écrit :

Hello and thanks! I took a look and forked the repo now.

Once I get home later I'll fix it and create a pull request.

I am running stock Android 6.0.1 and the binary is still there, just at
a different location. I will of course make a fix with backwards
compatibility.

I will then also take a look and test it on vanilla Android N (AOSP 7)
in a virtual machine once home.

There is of course a possibility that it's just my manufacturer that put
things in different places, we'll see.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#17 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGKx70n7akMkAgKV2pnOzGVmJrBVeJvks5q1NHLgaJpZM4KX7Nv.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rorist/android-network-discovery","title":"rorist/android-network-discovery","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open
in
GitHub","url":"https://github.com/rorist/android-network-discovery"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sindastra
in #17: Hello and thanks! I took a look and forked the repo
now.\r\n\r\nOnce I get home later I'll fix it and create a pull
request.\r\n\r\nI am running stock Android 6.0.1 and the binary is still
there, just at a different location. I will of course make a fix with
backwards compatibility.\r\n\r\nI will then also take a look and test it
on vanilla Android N (AOSP 7) in a virtual machine once
home.\r\n\r\nThere is of course a possibility that it's just my
manufacturer that put things in different places, we'll
see."}],"action":{"name":"View
Issue","url":"https://github.com/rorist/android-network-discovery/issues/17#issuecomment-254517295"}}}